[PATCH 11/11] docker: Don't require rebuilding if unnecessary
Petr Vorel
petr.vorel at gmail.com
Wed Jun 27 14:38:29 AEST 2018
Hi Stephen,
> +++ b/tools/docker/entrypoint.sh
> @@ -69,9 +69,10 @@ fi
> for x in /tmp/requirements-*.txt; do
> if ! cmp $x ~/patchwork/$(basename $x); then
> echo "A requirements file has changed."
> - echo "Please rebuild the patchwork image:"
> + echo "You may need to rebuild the patchwork image:"
> echo " docker-compose build web"
> - exit 1
> + echo ""
> + diff -u $x ~/patchwork/$(basename $x)
I'd use 'cat << EOF' instead of many echoes.
But that's just a minor nit, unrelated much to this patch (I see that's the
style written in entrypoint.sh).
Kind regards,
Petr
More information about the Patchwork
mailing list