[PATCH v2] Avoid timezone confusion

[Stephen Finucane]

On Wed, 2018-01-17 at 19:18 +0000, Stephen Finucane wrote:
> On Tue, 2018-01-16 at 18:58 +0100, vkabatov at redhat.com wrote:
> > From: Veronika Kabatova <vkabatov at redhat.com>
> > 
> > Patchwork saves patches, comments etc with UTC timezone and reports
> > this time when opening the patch details. However, internally
> > generated
> > processes such as events are reported with the instance's local
> > time.
> > There's nothing wrong with that and making PW timezone-aware would
> > add
> > useless complexity, but in a world-wide collaboration a lot of
> > confusion
> > may arise as the timezone is not reported at all. Instance's local
> > time
> > might be very different from the local time of CI integrating with
> > PW,
> > which is different from the local time of person dealing with it
> > etc.
> > 
> > Use UTC everywhere by default instead of UTC for sumbissions and
> > local
> > timezone for internally generated events (which is not reported).
> > 
> > Signed-off-by: Veronika Kabatova <vkabatov at redhat.com>
> 
> What effect does this have on existing information in the database?
> Does this mean they'll all remain UTC+12 or are they stored in UTC
> format already? The Django docs [1] would lead me to suggest the
> former, given that we don't have USE_TZ set to True.
> 
> I guess you can test that by setting up a deployment, creating
> information, then switching this option over. I'd do this myself but
> I'm not going to have time this week :(

Might be relevant.

  https://gist.github.com/aaugustin/2971450

Stephen

> Stephen
> 
> [1] https://docs.djangoproject.com/en/2.0/topics/i18n/timezones/
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork