Events for new comments for a patch series?

[Stephen Finucane]

On Mon, 2017-12-18 at 16:23 -0500, Don Zickus wrote:
> Hi,
> 
> I was playing with the events REST API interface and realized how
> convenient the 'series-completed' category is.
> 
> I was curious if there is also a way to be notified if a new comment
> arrived for a patch series.  We tend to use replies to patches as
> tags for meta info.  For example, acked-by, nacked-by, and also
> Bugzilla. There are times when a patch submitter forgets to add a
> Bugzilla id or another id is added because the patch solves another
> person's problem too.
> 
> Instead of reposting the patch series with the updated info, we tend
> to parse the comment and update some internal tags that is connected
> with the patch.
> 
> I was thinking, if having a 'events' interface that notified us a
> certain patch series had 'new comments', our polling script could
> retrieve and parse those comments.

That sounds like something we could do. I did this in the initial
version of the feature because I didn't think comments were valuable
enough to expose. Perhaps I've called that wrong though. How would this
compare with the Bugzilla-as-a-tag idea you've been discussing
elsewhere though?

> Or maybe simpler, just a 'comments' REST API that when combined with
> project and since could achieve the same thing.

Why not both? '/events' is mostly there as an ease-of-use thing, as it
represents the one place that one can find out about all the things
going on in the system. There's no reason we couldn't do, for example,
'/patches/{patchId}/comments' though.

Cheers,
Stephen

PS: I thought I'd replied to this before the break. Evidently not.
Sorry about that.