[PATCH v3] Avoid timezone confusion

Stephen Finucane stephen at that.guru
Tue Feb 27 22:31:22 AEDT 2018

On Thu, 2018-02-22 at 16:24 +0100, vkabatov at redhat.com wrote:
> From: Veronika Kabatova <vkabatov at redhat.com>
> Patchwork saves patches, comments etc with UTC timezone and reports
> this time when opening the patch details. However, internally generated
> processes such as events are reported with the instance's local time.
> There's nothing wrong with that and making PW timezone-aware would add
> useless complexity, but in a world-wide collaboration a lot of confusion
> may arise as the timezone is not reported at all. Instance's local time
> might be very different from the local time of CI integrating with PW,
> which is different from the local time of person dealing with it etc.
> Use UTC everywhere by default instead of UTC for sumbissions and local
> timezone for internally generated events (which is not reported).
> Signed-off-by: Veronika Kabatova <vkabatov at redhat.com>

This all looks good to me and you've resolved Daniel's once outstanding
comment via the additional reno. As such,

Reviewed-by: Stephen Finucane <stephen at that.guru>

I'll give it a few days to give Daniel the chance to sign off before
applying this.


More information about the Patchwork mailing list