[PATCH v2] Fix CRLF newlines upon submission changes
stephen at that.guru
Fri Feb 9 21:27:52 AEDT 2018
On Wed, 2018-02-07 at 14:23 +0100, vkabatov at redhat.com wrote:
> From: Veronika Kabatova <vkabatov at redhat.com>
> After changing submission via admin interface, CRLF newlines are
> suddenly present in the body. Replace them back to '\n'.
> The issue was found after modifying submission via admin interface
> using Python 2 and downloading the respective mbox file (git choked on
> downloaded patch because of malformed line endings). Python 3's mail
> module uses '\n' internally so the problem doesn't manifest there, but
> the content received by Django/JS is still saved in the database with
> CRLF line endings which shouldn't be there.
> Signed-off-by: Veronika Kabatova <vkabatov at redhat.com>
Looks a-ok to me. Thanks!
Reviewed-by: Stephen Finucane <stephen at that.guru>
More information about the Patchwork