[PATCH] docker: Use heredocs where possible

Stephen Finucane stephen at that.guru
Thu Aug 30 18:35:44 AEST 2018


On Wed, 2018-08-29 at 20:47 +0200, Petr Vorel wrote:
> Hi Stephen,
> > This was suggested in a recent review [1]. Make it happen.
> > [1] http://patchwork.ozlabs.org/patch/933979/#1941584
> > Signed-off-by: Stephen Finucane <stephen at that.guru>
> > Suggested-by: Petr Vorel <petr.vorel at gmail.com>
> 
> Reviewed-by: Petr Vorel <pvorel at suse.cz>
> > ---
> 
> LGTM, thanks for taking care for it.

Thanks, applied.

> Next step could be to remove bashisms and have it as a posix shell script with
> /bin/sh (I can do it).

Happy to review this, if you fancy tackling it.

Stephen

> Kind regards,
> Petr




More information about the Patchwork mailing list