[PATCH] Find patches, cover letters and comments by msgid
torvalds at linux-foundation.org
Mon Aug 27 04:09:31 AEST 2018
On Sun, Aug 26, 2018 at 7:14 AM Daniel Axtens <dja at axtens.net> wrote:
> This patch doesn't expose these URLs in the UI anywhere. I'd love to
> know where people would like them to go. I hesitate to make the
> message-id clickable in the patch detail view, as I think that would
> break workflows for people who want to copy the msgid to the clipboard.
So just to start off: I'm not personally a heavy patchwork user, but I
end up occasionally using it particularly when there's a bug report
and the issue bisects down to something that then has a patchwork
I've also mostly seen old versions of patchwork becasue of kernel.org
not having been up-to-date.
Take this to mean that my opinions on this may be skewed and not
necessarily those of heavy users.
But given that, I'd really like to see a pointer to the actual email
in the header line not just of the original email with the patch, but
of every comment. Right now patchwork (well, at least on kernel.org)
has that separate header area for that particular patchwork entry, I
don't mean that. I mean the line that right now has a pointer to the
author of each comment, and a date.
Add a clickable link to just after the name of the person making the
comment? Or even make the existing (mostly useless) date clickable?
Also, since the first email is likely the one you care about most,
also make the "Message ID" string itself clickable (in _addition_ to
the one-line header for the "Commit message" like all the "Comments").
I agree that the actual string that contains the message ID itself
might be best not be clickable for the whole copy-paste reason you
mention, but the actual "Message ID" string itself could be clickable,
IOW (sorry for the ugly ASCII barfic), in the header of the whole
thing, you'd have:
Message ID 20180826141413.3033-1-dja at axtens.net
| +--- not clickable to make
| copy-paste easy
+------ clickable, to get to the email
and then in the header for the individual "Commit message" and
"Comments", you'd have
Daniel Axtens [ msg ] Mon, 27 Aug 2018 00:14:13
| +--- clickable, goes to the message
+------ clickable, goes to the person
Or _something_ along these lines. Maybe instead of that added "[msg]"
thing, just make the date clickable and get to the email instead.
More information about the Patchwork