[PATCH v2 2/3] Default dev settings, set host to empty (unix socket) on postgresql
Daniel Axtens
dja at axtens.net
Wed Aug 22 02:02:20 AEST 2018
>> Why should we test with local domain sockets rather than with
>> localhost?
>
> You should test both connection types are possible in patchwork.
> Obviously the end result is the same however.
OK, I understand now, thank you for your patience!
I think this probably falls into the category of testing Django rather
than testing Patchwork: db connection handling is something we directly
inherit from Django and don't mess with.
However, it seems that postgres by default will only accept passwordless
auth over a unix socket. This has been tweaked on the versions supplied
in the Travis image, allowing passwordless connections over the network
as well, but because Postgres 10/11 aren't part of the image, this
tweaking isn't done for them - [1]. This causes failures such as [2].
So what I have done is squashed this patch into patch 1 and applied the
combined patch and patch 3.
You can see it in action at
https://travis-ci.org/getpatchwork/patchwork/builds/418771098
Welcome to the Patchwork Contributors Club, and thank you :)
Regards,
Daniel
[1] https://github.com/travis-ci/travis-ci/issues/9624
[2] https://travis-ci.org/daxtens/patchwork/jobs/418742513#L603
More information about the Patchwork
mailing list