[PATCH 00/11] Add labels support

[Daniel Axtens]

Stephen Finucane <stephen at that.guru> writes:

> I want to add support for global series states, as noted in #157 [1]
> However, to get there we're going to need a boolean open/closed
> attribute for 'Patch.state' and to get _there_ we're going to need to
> clean up the various 'State' fixtures, as noted in #4 [2].

I'm very happy to get states into bundles and series. But I don't
understand why it needs to be boolean to allow this?

> This series starts work on the latter of these by addressing yet another
> issues, #22 [3]. Full details of the feature are provided inline but
> tl;dr labels are arbitrary bits of metadata that can be used to
> represent some of the more orthogonal states like "RFC" or "Under
> Review" along with other maintainer-provided labels. Once we have
> support for this, we can build upon it to migrate some of the 'states'
> to labels and the 'state' field itself to a boolean field. This is all
> in the future though.

So I haven't read through the patches in great detail, but I want to
just query the idea that RFC is orthogonal. I understand a bunch of
maintainers have a general policy of not merging RFC patches, so if
something is posted as RFC they just mark it as RFC on Patchwork and
then don't ever look at it again.

> [1] https://github.com/getpatchwork/patchwork/issues/157

Regarding this one:
> [2] https://github.com/getpatchwork/patchwork/issues/4

OzLabs does have some different tags to the default: e.g. "Needs Review
/ ACK". So we might need to reconsider the basis for this

Regarding this one:
> [3] https://github.com/getpatchwork/patchwork/issues/22
Do we have users wanting this one? I'm just really really leery making
bigger sorts of changes until we pay down a _lot_ of our technical debt.

Regards,
Daniel

>
> Stephen Finucane (11):
>   fields: Add ColorField
>   models: Add patch labels
>   parser: Extract and save labels
>   parser: Remove matching label from subject prefixes
>   admin: Group register calls at bottom
>   admin: Add label views
>   views: Populate 'project' attribute of PatchForm
>   views: Add patch labels to web UI
>   REST: Expose Patch.labels
>   docs: Add information on labels
>   docs: Random fixes
>
>  docs/api/index.rst                            |   2 +
>  docs/deployment/index.rst                     |   2 +
>  docs/development/api.rst                      |   6 +-
>  docs/development/index.rst                    |   2 +
>  docs/index.rst                                |  19 ----
>  docs/releases/index.rst                       |   2 +
>  docs/usage/delegation.rst                     |   3 -
>  docs/usage/index.rst                          |   2 +
>  docs/usage/overview.rst                       | 153 +++++++++++---------------
>  patchwork/admin.py                            |  61 +++++-----
>  patchwork/api/patch.py                        |  12 +-
>  patchwork/fields.py                           |  27 ++++-
>  patchwork/fixtures/default_labels.xml         |   9 ++
>  patchwork/forms.py                            |  44 +++++++-
>  patchwork/migrations/0026_add_patch_labels.py |  39 +++++++
>  patchwork/models.py                           |  35 ++++++
>  patchwork/parser.py                           |  22 ++++
>  patchwork/templates/patchwork/patch-list.html |   8 ++
>  patchwork/templates/patchwork/submission.html |   7 ++
>  patchwork/templatetags/patch.py               |  24 ++++
>  patchwork/tests/test_parser.py                |  23 ++++
>  patchwork/tests/utils.py                      |  15 +++
>  patchwork/views/__init__.py                   |   2 +-
>  patchwork/views/patch.py                      |   5 +-
>  24 files changed, 369 insertions(+), 155 deletions(-)
>  create mode 100644 patchwork/fixtures/default_labels.xml
>  create mode 100644 patchwork/migrations/0026_add_patch_labels.py
>
> -- 
> 2.14.3
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork