[PATCH] api: Show all headers with the same key

Stephen Finucane stephen at that.guru
Thu Apr 26 06:09:58 AEST 2018


On Tue, 2018-04-24 at 23:23 +0100, Stephen Finucane wrote:
> On Fri, 2018-04-06 at 13:24 +0200, vkabatov at redhat.com wrote:
> > From: Veronika Kabatova <vkabatov at redhat.com>
> > 
> > While the code on our side returns all (key, value) pairs for email
> > headers, Django's REST framework probably uses dictionaries behind the
> > scenes. This means that having multiple headers with same key (eg
> > 'Received', which is totally valid and common situation), only one of
> > these headers is visible in the REST API.
> > 
> > Let's hack around this by returning a list of values in case the key is
> > present multiple times.
> > 
> > Signed-off-by: Veronika Kabatova <vkabatov at redhat.com>
> 
> Sorry for the delay in getting to this. This looks good but I feel it
> needs a regression test. If you could provide one, I'd be happy to
> squash it in here and apply this.

With the follow up patch added to this, I'm happy to apply it.

Reviewed-by: Stephen Finucane <stephen at that.guru>


More information about the Patchwork mailing list