[PATCH 4/4] Test postgresql support in Travis CI

Daniel Axtens dja at axtens.net
Tue Sep 26 21:27:25 AEST 2017


Hi Stephen,

>> +dist: trusty
>
> Why is this trusty rather than xenial?

Because Travis suuuper out of date, it supports precise and trusty for
now.

>
>>  sudo: false
>>  
>>  python:
>> @@ -7,17 +8,24 @@ python:
>>    - 3.4
>>    - 3.5
>>  
>> +addons:
>> +  postgresql: "9.6"
>> +
>>  services:
>>    - mysql
>> +  - postgresql
>>  
>>  env:
>> +  matrix:
>> +    - PW_TEST_DB_TYPE=postgres PW_TEST_DB_USER=postgres
>> +    - PW_TEST_DB_TYPE=mysql PW_TEST_DB_USER=root
>
> Related to the above?
>
Yes, this gives us a matrix with two entries, one postgres and one mysql.

>>    global:
>> -    - PW_TEST_DB_USER=travis
>>      - PW_TEST_DB_PASS=""
>>      - PW_SKIP_BROWSER_TESTS=yes
>>  
>>  before_script:
>>    - mysql -e 'create database patchwork character set utf8;'
>> +  - psql -c "create database patchwork with ENCODING = 'UTF8';" -U postgres
>>  
>>  install:
>>    - pip install tox-travis
>
> Can't argue with any of this, to be honest. However, I'm assuming you've tested
> this against your private repo. Does it work with tox-travis as expected? I'd
> expect to see 2x the # of jobs - are we seeing these?
>
Yes: https://travis-ci.org/daxtens/patchwork/builds/271401910
(v2 to come soon)

Regards,
Daniel


More information about the Patchwork mailing list