[PATCH v2] xmlrpc/patch_list: only fetch required fields

[Stephen Finucane]

On Thu, 2017-10-19 at 02:53 +1100, Daniel Axtens wrote:
> OzLabs noticed *massive* slowdowns in queries like this one:
> 
> SELECT "patchwork_submission"."id", "patchwork_submission"."msgid",
> "patchwork_submission"."date", "patchwork_submission"."headers",
> "patchwork_submission"."submitter_id",
> "patchwork_submission"."content", "patchwork_submission"."project_id",
> "patchwork_submission"."name", "patchwork_patch"."submission_ptr_id",
> "patchwork_patch"."diff", "patchwork_patch"."commit_ref",
> "patchwork_patch"."pull_url", "patchwork_patch"."delegate_id",
> "patchwork_patch"."state_id", "patchwork_patch"."archived",
> "patchwork_patch"."hash" FROM "patchwork_patch" INNER JOIN
> "patchwork_submission" ON ("patchwork_patch"."submission_ptr_id" =
> "patchwork_submission"."id") WHERE
> ("patchwork_submission"."project_id" = 2 AND
> "patchwork_patch"."state_id" = 1) ORDER BY
> "patchwork_submission"."date" ASC
> 
> These appear to be a result of pwclient list operations. We *do not*
> need content/headers/diff in this case - so do not fetch them as it
> is incredibly expensive - queries in excess of 50s have been observed.
> 
> This should go to stable/2.0.
> 
> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> Reported-by: Michael Ellerman <mpe at ellerman.id.au>
> Cc: Jeremy Kerr <jk at ozlabs.org>
> Signed-off-by: Daniel Axtens <dja at axtens.net>

This all looks fine to me. I guess the combination of patch and comment 0 is
what caused this.

Reviewed-By: Stephen Finucane <stephen at that.guru>