pwclient get command error

[Stephen Finucane]

On Fri, 2017-05-19 at 15:59 +0100, Stephen Finucane wrote:
> On Fri, 2017-05-19 at 21:39 +1000, Daniel Axtens wrote:
> > Hi all,
> > 
> > I was attempting to use pwclient to fetch the Django 1.11 series*,
> > and
> > ran the following command, which errored out:
> > 
> > $ ./patchwork/bin/pwclient get 760803
> > Traceback (most recent call last):
> >   File "./patchwork/bin/pwclient", line 820, in <module>
> >     main()
> >   File "./patchwork/bin/pwclient", line 773, in main
> >     action_get(rpc, patch_id)
> >   File "./patchwork/bin/pwclient", line 307, in action_get
> >     f.write(s)
> > TypeError: write() argument 1 must be unicode, not str
> 
> Odd. I get a completely different issue, but I think that's some
> misconfiguration somewhere. I'll investigate. In the interim, can you
> try with commit '53fe8b1' of pwclient? The next commit to modify that
> file, '52654da', looks like it _could_ be related?

Actually, it's commit '046419a3' :( I've no idea where to start fixing
this now, aside from a complete revert (part of it was reverted in
'a3911c5b'). However, this reintroduces the problems that that patch
intended to fix in the first place. Sigh...

I'm going to revert those changes for now, to fix things for the
majority using Python 2. I'll take a look over the weekend for a more
permanent fix. I'll probably add some tests too, because pwclient
_really_ needs tests, clearly.

Stephen

> 
> > My pwclientrc contains:
> > 
> > [options]
> > default=patchwork
> > 
> > [patchwork]
> > url= https://patchwork.ozlabs.org/xmlrpc/
> > 
> > This breaks with python2 but works with python3:
> > $ python3 ./patchwork/bin/pwclient get 760803
> > Saved patch to 01-19-settings-Enable-
> > SessionAuthenticationMiddleware.patch.1
> > 
> > Regards,
> > Daniel
> > 
> > * Stephen, any chance of putting that on GitHub somewhere, please?
> > Much obliged :)
> 
> Sure thing - https://github.com/stephenfin/patchwork/tree/django-1-11
> 
> Stephen
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork