Anyone care for Django 1.11 in 2.0?

[Stephen Finucane]

On Fri, 2017-05-19 at 09:41 +1000, Daniel Axtens wrote:
> Hi Stephen,
> 
> Apologies for being so slow on this - I'm planning to have a look at
> Django 1.11 today/this afternoon - will let you know if I can confirm
> your findings and if I see any obvious fixes or other issues.

It's all good :)

Regarding 1.11: while the performance issue is a big deal, there's also
the fact that Django REST Framework (DRF) doesn't officially support
Django 1.11 yet. DRF 3.7.0 isn't expected until the end of July [1] and
we can't wait for that. Even if the performance issues are a non-issue
or can be resolved, I think we're better off cutting with Django 1.10
and including 1.11 support in Patchwork 2.1. Thoughts?

Cheers,
Stephen

[1] https://github.com/encode/django-rest-framework/milestone/49

> Daniel
> 
> Finucane <stephen at that.guru> writes:
> 
> > On Thu, 2017-05-11 at 05:12 +1000, Daniel Axtens wrote:
> > > Hi Stephen,
> > > 
> > > > Yet another poll for interest.
> > > > 
> > > > I have a series that adds support for Django 1.11 and resolves
> > > > all "removed in 2.0" deprecation warnings. It's mostly noddy*
> > > > stuff but weighs in at ~15 patches. Does anyone care enough
> > > > about Django 1.11 support to squeeze it in before 2.0? If not,
> > > > I'll hold it for 2.1.
> > > > 
> > > 
> > > Given how long people tend to run their patchwork instances
> > > without updating (literally years!), we probably want to be able
> > > to run on as recent a version as possible. So yeah, let's plug
> > > this in and do an rc2 to check for regressions. (Sorry to drag
> > > the process out!)
> > > 
> > > Hopefully I will get my .patchwork.dja.id.au stuff updated to rc1
> > > real soon now.
> > > 
> > > Regards,
> > > Daniel
> > 
> > Update on this. On further testing last night, I've seen some
> > performance issues with Django 1.11 and the REST API. In some
> > cases, list operations (/patches) against a development instance
> > took ~30 seconds rather than the usual 400-600 mSec response time.
> > Adding filtering to this doubled or tripled the response time.
> > 
> > Coupled with the fact that Django REST Framework doesn't yet
> > officially support Django 1.11, I'm no longer comfortable merging
> > these patches this late in the day. I'm going to merge the
> > DeprecationWarning fixes for Django versions < 1.10 as part of RC2
> > (probably tonight), but I'll defer the remainder until Patchwork
> > 2.1. Hopefully this doesn't affect anyone.
> > 
> > Cheers,
> > Stephen