[PATCH v3 3/5] views: Stop using Bundle.public_url

Stephen Finucane stephen at that.guru
Thu Mar 23 23:40:06 AEDT 2017

On Thu, 2017-03-23 at 12:59 +1100, Daniel Axtens wrote:
> Hi Stephen,
> I see you've merged this series, but I don't think the public URL is
> the
> same as the mbox url.
> I created a public bundle in one of my old test instances and
> navigated to
> http://localhost:8000/project/patchwork/bundles/
> This gave me a public url of    http://example.com/bundle/dja/aaa/
> and an mbox url of              http://localhost:8000/bundle/dja/aaa/
> mbox/
> The public URL, once corrected for the hostname, takes me to a bundle
> detail page, which is distinct from the mbox view.
> Am I missing something here?
> Regards,
> Daniel

Oh, damn - good spot. You're not mistaken - 'public_url' reversed
'bundle-detail' and not 'bundle-mbox'. 'public_url' should have been
updated to use 'reverse' rather than manually building the URL but it
is still a different resource.

I'll re-add that shortly, and revert the 'public_url' -> 'get_mbox_url'


More information about the Patchwork mailing list