[PATCH v2 6/6] REST: Add '/bundle' endpoint

Stephen Finucane stephen at that.guru
Fri Mar 17 06:10:18 AEDT 2017


On Tue, 2017-03-14 at 10:48 -0500, Andy Doan wrote:
> On 03/07/2017 01:22 PM, Stephen Finucane wrote:
> > I had initially resisted adding a '/bundle' endpoint to the API as
> > I
> > wanted to kill this feature in favour of series. However, series
> > are not
> > a like-for-like replacement for bundles. Among other things, series
> > do
> > not provide the composability of bundles: bundles can be manually
> > created, meaning you can use bundles to group not only multiple
> > patches
> > but also multiple series (or at least the patches in those series).
> > 
> > Seeing as we're not getting rid of this feature, we should expose
> > it via
> > the API. Bundles are little unusual, in that they can be public or
> > private, thus, we should only show bundles that are public or
> > belonging
> > to the currently authenticated user, if any. For now, this is a
> > read-only endpoint. We may well allow creation of bundles via the
> > API
> > once we figure out how to do this cleanly.
> > 
> > Signed-off-by: Stephen Finucane <stephen at that.guru>
> > Cc: Andy Doan <andy.doan at linaro.org>
> 
> This looks fine to me. Two things though:
> 
> 1) Can you add some unit tests for this?

Sure. Coming right up.

> 2) Are you planning a follow on patch to allow updates via this
> endpoint?

What kind of updates are you thinking of? I guess we could do bundle
renaming but that doesn't seem all that useful. Anything else?

Stephen


More information about the Patchwork mailing list