[PATCH v3 8/9] templates: Use buttons for patch download links

Stephen Finucane stephen at that.guru
Sat Mar 11 04:40:55 AEDT 2017

On Thu, 2017-03-09 at 17:38 +1100, Daniel Axtens wrote:
> Stephen Finucane <stephen at that.guru> writes:
> So, I've polled users, and the feedback is that people don't
> particularly care about the button vs link thing or the placement on
> the
> right, (so long as they can still right click to get a link), but
> people
> would really like buttons up the top of the page as well as at the
> top
> of the patch.
> I'm happy to do that as a follow up if you'd like.
> I've also got a few other UI requests which I'll do in a series.

That sounds like the best option, yes. I'd be happy to review that

> In my testing, it looks like the buttons act as toggle buttons rather
> than momentary (i.e. they 'stay pressed') - does this happen to you
> too?
> I use Chrome.

They're not pressed - they have focus. You'd see the same thing if you
tabbed down to them. Unfortunately there's no way around this without
some hacky JavaScript which isn't worth it (IMO, at least :))


More information about the Patchwork mailing list