[PATCH v2 8/9] templates: Use buttons for patch download links

Stephen Finucane stephen at that.guru
Wed Mar 8 06:29:12 AEDT 2017

On Fri, 2017-02-24 at 14:47 +1100, Daniel Axtens wrote:
> Hi Stephen,
> > + <div class="btn-group pull-right">
> I've just applied this - I'm not convinced about the 'pull-right':
>  - Potentially more mouse travel required.
>  - familiarity; I know where to look in the old system
> Neither are very strong objections but I'd like to know if you've
> throught about them and had a reason for moving it.

The main reason I move them across is that they look odd beside the
heading due to the height differences. I figured this was a common
enough convention and "power users" would be using something like
'pwclient' anyway. Perhaps you could try removing the pull-right
locally and let me know if you think it's acceptable?

> Apart from that I like it.
> (Now if only we had a nice big user base we could do A/B testing on!)

Aye - I'm trying to guess what users would be happy with, rather than
validating it. Not much I can do about that though :)


More information about the Patchwork mailing list