[PATCH v2 6/9] views: Add 'series' parameter to '/mbox' endpoint

Stephen Finucane stephen at that.guru
Wed Mar 8 06:25:26 AEDT 2017


On Fri, 2017-02-24 at 14:22 +1100, Daniel Axtens wrote:
> Hi Stephen,
> 
> 
> > +    # get the series-ified patch
> > +    number = series.seriespatch_set.get(patch=patch).number
> > +    for dep in series.seriespatch_set.filter(number__lt=number):
> > +        mbox.append(patch_to_mbox(dep.patch))
> 
> I can't remember if I raised this already, but do we care if we don't
> have a complete set of preceeding patches? (e.g. 4, 3 and 1 but not
> 2)

I didn't do anything here - I figured CI systems would be monitoring
the events stream and would only pull in mbox files that way. I can do
this (perhaps with a 'force' parameter) but ideally as a follow up to
get this in, if that's OK with you?

Stephen

> Regards,
> Daniel
> 
> > +
> > +    mbox.append(patch_to_mbox(patch))
> > +
> > +    return '\n'.join(mbox)
> > -- 
> > 2.9.3
> > 
> > _______________________________________________
> > Patchwork mailing list
> > Patchwork at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/patchwork



More information about the Patchwork mailing list