[PATCH 2/5] htdocs: Add clipboard.js

[Stephen Finucane]

On Tue, 2017-06-13 at 21:35 +1000, Andrew Donnellan wrote:
> On 10/06/17 03:25, Stephen Finucane wrote:
> > We provide our own, much smaller implementation of this currently.
> > However, we want to be able to implement slightly different variants of
> > this elsewhere and using an existing library helps avoid reinventing the
> > wheel and lets us use already battle-tested code.
> > 
> > Signed-off-by: Stephen Finucane <stephen at that.guru>
> 
> One comment below
> 
> Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> 
> > ---
> > We should probably look at integrating Django Compressor in a future
> > release, as the number of JS files we have is slowly increasing. Work
> > for v2.1.0.
> > ---
> >  htdocs/README.rst                             | 10 ++++++++++
> >  htdocs/js/bundle.js                           |  2 +-
> >  htdocs/js/clipboard.min.js                    |  7 +++++++
> >  patchwork/templates/patchwork/patch-list.html | 20 +++++---------------
> >  templates/base.html                           |  6 ++++++
> >  5 files changed, 29 insertions(+), 16 deletions(-)
> >  create mode 100644 htdocs/js/clipboard.min.js
> > 
> > diff --git a/htdocs/README.rst b/htdocs/README.rst
> > index 513fb24..62f15c2 100644
> > --- a/htdocs/README.rst
> > +++ b/htdocs/README.rst
> > @@ -65,6 +65,16 @@ js
> > 
> >    Part of Patchwork.
> > 
> > +``clipboard.min.js``
> > +
> > +  Modern copy to clipboard. No Flash. Just 3kb gzipped
> > +
> > +  This is used to allow us to "click to copy" various elements in the UI.
> > +
> > +  :Website: https://clipboardjs.com/
> > +  :GitHub: https://github.com/zenorocha/clipboard.js/
> > +  :Version: 1.7.1
> > +
> >  ``jquery.js``
> > 
> >    jQuery is a fast, small, and feature-rich JavaScript library. It makes
> > things
> > diff --git a/htdocs/js/bundle.js b/htdocs/js/bundle.js
> > index c969d0b..e27c091 100644
> > --- a/htdocs/js/bundle.js
> > +++ b/htdocs/js/bundle.js
> > @@ -1,4 +1,3 @@
> > -
> >  var editing_order = false;
> >  var dragging = false;
> > 
> > @@ -63,6 +62,7 @@ function drag_hover_in()
> >      if (!dragging)
> >          $(this).addClass("draghover");
> >  }
> > +
> >  function drag_hover_out()
> >  {
> >      $(this).removeClass("draghover");
> 
> This hunk seems unnecessary?

Resolved this and applied.

Stephen