[PATCH 3/5] REST: Enable token auth support

Stephen Finucane stephen at that.guru
Wed Jun 14 18:57:49 AEST 2017


On Tue, 2017-06-13 at 21:38 +1000, Andrew Donnellan wrote:
> On 10/06/17 03:25, Stephen Finucane wrote:
> > Token authentication is generally viewed as a more secure option for API
> > authentication than storing a username and password.
> > 
> > Django REST Framework gives us a TokenAuthentication class and an authtoken
> > app that we can use to generate random tokens and authenticate to API
> > endpoints. Enable this support and add some tests to validate correct
> > behavior.
> > 
> > Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> > Signed-off-by: Stephen Finucane <stephen at that.guru>
> 
> Changes from my RFC (that I spotted on first reading):
> 
> * add token property on Person
> * add tests
> * split out regenerate_token()
> 
> All looks good to me!

That probably should have been in the commit message but yup, that's about it.

Applied this and included it in rc4.

Cheers,
Stephen


More information about the Patchwork mailing list