[PATCH v2 8/9] templates: Use buttons for patch download links

Daniel Axtens dja at axtens.net
Fri Feb 24 14:47:55 AEDT 2017


Hi Stephen,

> + <div class="btn-group pull-right">

I've just applied this - I'm not convinced about the 'pull-right':
 - Potentially more mouse travel required.
 - familiarity; I know where to look in the old system

Neither are very strong objections but I'd like to know if you've
throught about them and had a reason for moving it.

Apart from that I like it.

(Now if only we had a nice big user base we could do A/B testing on!)

Regards,
Daniel

> +  <a href="{% url 'patch-raw' patch_id=submission.id %}"
> +   class="btn btn-default" role="button" data-toggle="tooltip"
> +   title="Download patch diff">diff</a>
> +  <a href="{% url 'patch-mbox' patch_id=submission.id %}"
> +   class="btn btn-default" role="button" data-toggle="tooltip"
> +   title="Download patch mbox">mbox</a>
> + </div>
>  </h2>
> +
>  <div id="patch" class="patch">
>  <pre class="content">
>  {{ submission|patchsyntax }}
> -- 
> 2.9.3
>
> _______________________________________________
> Patchwork mailing list
> Patchwork at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork


More information about the Patchwork mailing list