[PATCH v2] REST: Don't iterate through models at class level

Stephen Finucane stephen at that.guru
Wed Feb 8 00:05:48 AEDT 2017


On Tue, 2017-02-07 at 13:47 +0100, Denis Laxalde wrote:
> Stephen Finucane a écrit :
> > his causes two issues. Firstly, on fresh installs you see the
> > following
> > error message:
> > 
> >   "Table 'patchwork.patchwork_state' doesn't exist"
> > 
> > Secondly, any new states created when the process is running will
> > not be
> > reflected in the API until the server process is restarted.
> 
> I can confirm that this version fixes both issues now. Thanks!

Excellent. Any chance of a 'Tested-by'? :)

> > Resolve this issue by moving the step into a method, thus ensuring
> > it's
> > continuously refreshed. It doesn't seem possible to add tests to
> > prevent
> > this regressing but some similarly useful tests are included to at
> > least
> > validate the behavior of that field.
> > 
> > ---
> > v2:
> > - Use a subclass of RelatedField instead to ensure lazy-loading of
> > the
> >   queryset
> > - Improve tests by checking error messages and removing unnecessary
> >   checks
> 
> Maybe the commit message should be updated to include these points?

+1. I'll add this when I merge.

Stephen


More information about the Patchwork mailing list