[PATCH v2 1/6] models: Move signal to 'signals'

Stephen Finucane stephen at that.guru
Tue Feb 7 08:43:56 AEDT 2017

On Tue, 2017-02-07 at 08:08 +1100, Daniel Axtens wrote:
> Hi Stephen,
> This looks good, but I'm not sure I understand the use of
> AppConfig. Given that we are supporting pre-AppConfig Django, what
> benefit do we get from also having AppConfig?

So AppConfig is what we need if we ever wish to package Patchwork as an
app that people can install from a Python package/pip. That's not why I
included it here though. Instead, I've been following the docs and this
is what one they suggest doing to use signals in Django >= 1.7 [1].
IMO, following the docs where possible helps with the principle of
least astonishment. There's also the fact that I plan to kill Django
1.6 and 1.7 support at some point in the future (they're ancient at
this point). Together, they seemed like a good reason to do this work
now and save us the effort later. 

> It could just be that I'm a bit out of the loop on Django and it's
> actually super awesome - feel free to point me at anything I should
> go
> and read.

I had to go and double check why I did this myself, so it's definitely
a good thing to question :)

[1] http://stackoverflow.com/a/21612050/613428


More information about the Patchwork mailing list