[PATCH 5/6] templates: Use buttons for patch download links

[Daniel Axtens]

I've fat-fingered the initial response to this message and accidentally
omitted the list - here's the info for posterity.

Stephen, I'm going to actually apply the series and have a look -
hopefully today otherwise probably Monday. Thanks for the comments.

Stephen Finucane <stephen at that.guru> writes:

> On Thu, 2017-02-02 at 17:06 +1100, Daniel Axtens wrote:
>> Hi Stephen,
>> 
>> > We'll make use of this to enable downloading of patches with
>> > mboxes.
>> 
>> Will this lead to more vertical space being consumed by the buttons? 
>> I'm writing this on the bus so I haven't checked - I just wanted to
>> have
>> a bit of a think about whether or not that's acceptable or if people
>> are
>> going to be annoyed by bigger, more prominent buttons between them
>> and
>> the submitted patch...
>
> Nope - the buttons are on the same line as the 'Patch' header.
>
>> > 
>> > In addition, the 'hide' link for patches and cover letters is
>> > removed.
>> > There's no way to enable this by default and the use cases are
>> > dubious
>> > at best.
>> 
>> This seems fine.
>> 
>> > + <div class="btn-group pull-right">
>> > +  <a href="{% url 'patch-raw' patch_id=submission.id %}"
>> > +   class="btn btn-default" role="button" data-toggle="tooltip"
>> 
>> What does the data-toggle field do?
>
> It's a Bootstrap thing that makes the button a dropdown (anything with
> a 'data-' prefix is usually Bootstrap magic).
>
> Stephen