[PATCH 4/4] tox: Add 'bashate' target

[Stephen Finucane]

On Wed, 2017-02-01 at 23:35 +1100, Daniel Axtens wrote:
> Hi Stephen,
> 
> I'm quite happy with this series!
> 
> Reviewed-by: Daniel Axtens <dja at axtens.net>
> 
> A minor thought:
> 
> > +[testenv:bashate]
> > +deps = bashate>=0.5,<0.6
> > +whitelist_externals = bash
> > +commands =
> > +    bash -c "find {toxinidir} \
> > +    -not \( -type d -name .?\* -prune \) \
> > +    -not \( -type d -name db -prune \) \
> > +    -name \*.sh -print | xargs bashate"
> > +
> 
> We could install shellcheck in the docker container and make it
> usable
> that way? No strong feelings, just a thought.

Good point. I guess that would take the form of another tox target
('shellcheck')? I won't get around to doing it before 2.0, but if you
fancy whipping a patch up I'd be happy to apply it.

> Also, should this be a default check? I assume it's quite quick.

Yup, I'll make this a default check when I apply this.

Cheers for the review.

Stephen