[PATCH 2/6] views: Make 'patch_to_mbox' return a string

Stephen Finucane stephen at that.guru
Thu Feb 2 23:07:24 AEDT 2017

On Thu, 2017-02-02 at 13:58 +1100, Daniel Axtens wrote:
> Hi,
> > The 'patch_to_mbox' function returns an object which is coverted to
> > a
> > string in all places where this call occurs. The string conversion
> > differs between Python 2 and 3 and while one it has been updated in
> > one
> > place, it was missed in two others. Resole these issues and ensure
> > they
> > don't happen again by returns strings from 'patch_to_mbox' instead.
> Let me just reset the "Days since we encountered a bug that would
> have
> been avoided with a rigorous type system" counter to zero.

It might be a good idea to integrate mypy into this section of the code
in the future. For now though, this will have to do.


More information about the Patchwork mailing list