[PATCH 3/3] Add support for Python 3.6

Daniel Axtens dja at axtens.net
Mon Dec 4 09:53:51 AEDT 2017


Stephen Finucane <stephen at that.guru> writes:

> On Mon, 2017-12-04 at 09:32 +1100, Daniel Axtens wrote:
>> Stephen Finucane <stephen at that.guru> writes:
>> 
>> > This is simply a case of adding the required tox environment and
>> > updating the docs. We don't support Python 3.3 so the docs are
>> > updated
>> > accordingly.
>> > 
>> > Signed-off-by: Stephen Finucane <stephen at that.guru>
>> > ---
>> >  README.rst                                                  | 2 +-
>> >  releasenotes/notes/python-3-6-support-0cf90c2329075372.yaml | 5
>> > +++++
>> >  tox.ini                                                     | 2 +-
>> >  3 files changed, 7 insertions(+), 2 deletions(-)
>> >  create mode 100644 releasenotes/notes/python-3-6-support-
>> > 0cf90c2329075372.yaml
>> > 
>> > diff --git a/README.rst b/README.rst
>> > index 273fa9cd..44de7fc1 100644
>> > --- a/README.rst
>> > +++ b/README.rst
>> > @@ -41,7 +41,7 @@ of community projects.
>> >  Requirements
>> >  ------------
>> >  
>> > -- Python (2.7, 3.3 - 3.5)
>> > +- Python (2.7, 3.4 - 3.6)
>> >  
>> >  - Django (1.8 - 1.11)
>> >  
>> > diff --git a/releasenotes/notes/python-3-6-support-
>> > 0cf90c2329075372.yaml b/releasenotes/notes/python-3-6-support-
>> > 0cf90c2329075372.yaml
>> > new file mode 100644
>> > index 00000000..d31e17bd
>> > --- /dev/null
>> > +++ b/releasenotes/notes/python-3-6-support-0cf90c2329075372.yaml
>> > @@ -0,0 +1,5 @@
>> > +---
>> > +features:
>> > +  - |
>> > +    `Python 3.6 <https://www.python.org/downloads/release/python-3
>> > 50/>`_ is now
>> 
>> s/350/360/ perhaps?
>
> Good spot. I can fix this in a potential v3 or at merge time.
I haven't had a look at the other patches yet, if there isn't anything
that requries a v3 there I am happy for this to be a merge-time fix.

-- d

>
>> > +    supported.
>> > diff --git a/tox.ini b/tox.ini
>> > index bd8af767..b70b6057 100644
>> > --- a/tox.ini
>> > +++ b/tox.ini
>> > @@ -1,6 +1,6 @@
>> >  [tox]
>> >  minversion = 2.0
>> > -envlist = pep8,py{27,34,35}-django{18,19,110,111}
>> > +envlist = pep8,py{27,34,35}-django{18,19,110,111},py36-django111
>> >  skipsdist = True
>> >  
>> >  [testenv]
>> > -- 
>> > 2.14.3
>> > 
>> > _______________________________________________
>> > Patchwork mailing list
>> > Patchwork at lists.ozlabs.org
>> > https://lists.ozlabs.org/listinfo/patchwork
>> 
>> Apart from that,
>> Reviewed-by: Daniel Axtens <dja at axtens.net>
>> 
>> Regards,
>> Daniel


More information about the Patchwork mailing list