[PATCH 1/2] tests: Run FuzzTest within a transaction

Stephen Finucane stephen at that.guru
Thu Aug 31 18:43:42 AEST 2017


On Mon, 2017-08-28 at 14:08 +0100, Stephen Finucane wrote:
> On Mon, 2017-08-28 at 19:39 +0800, Jeremy Kerr wrote:
> > Currently, the FuzzTests fail for me with:
> > 
> > /backends/base/base.py", line 428, in validate_no_broken_transaction
> >     "An error occurred in the current transaction. You can't "
> > TransactionManagementError: An error occurred in the current transaction.
> > You
> > can't execute queries until the end of the 'atomic' block.
> > 
> > - because the SQL inserts can fail, during an active transaction (the
> > first failure I see is attempting to insert \0 chars in
> > codec-null.mbox); this causes the setup for the next test case to fail.
> > 
> > Instead, run each test in its own transaction.
> > 
> > Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> 
> Looks good to me, with one nit below (can be fixed at merge time).
> 
> Reviewed-by: Stephen Finucane <stephen at that.guru>

Both of these patches are now applied to 'master' and backported to
'stable/2.0'.

Stephen



More information about the Patchwork mailing list