[PATCH 2/3] 'mpe mode': click to copy patch IDs

Stephen Finucane stephen at that.guru
Sat Apr 15 04:58:21 AEST 2017


On Mon, 2017-04-10 at 08:25 +1000, Daniel Axtens wrote:
> Stephen Finucane <stephen at that.guru> writes:
> 
> > On Mon, 2017-03-27 at 16:42 +1100, Daniel Axtens wrote:
> > > If 'Show Patch IDs' is turned on in settings, add an extra column
> > > to the patch list, with buttons showing the patch IDs. The
> > > buttons
> > > copy the patch IDs to the clipboard.
> > > 
> > > JavaScript inspired by https://github.com/Triforcey/clip-j and
> > > many
> > > many StackOverflow answers.
> > > 
> > > Suggested-by: Michael Ellerman <mpe at ellerman.id.au>
> > > Signed-off-by: Daniel Axtens <dja at axtens.net>
> > 
> > This looks good to me. I do wonder if there's any reason not to
> > turn
> > this on by default though?
> 
> My thought was just to avoid messing around too much with the default
> UI
> that people are used to, especially since it's not entirely obvious
> what
> the buttons do just by looking at them.

Sounds fair. We can make this the default in the future if required.

Reviewed-by: Stephen Finucane <stephen at that.guru>

Stephen


More information about the Patchwork mailing list