[PATCH 4/4] tox: Test all supported versions of DRF

Stephen Finucane stephen at that.guru
Wed Apr 5 19:47:37 AEST 2017


On Wed, 2017-04-05 at 14:29 +1000, Daniel Axtens wrote:
> Hi Stephen,
> 
> Thanks for doing all of these - I will test them soon.

No problem. Do note that there's an apparent issue with DRF 3.4 and
Django 1.10. It _should_ work, but it gives an odd warning. You can
probably ignore that particular combination given the age gap between
them.

> > I'm not sure about this one: it's a _lot_ of extra testing that I'm
> > not
> > so sure people will run. I wonder if it's even worth it? Perhaps
> > Travis
> > could test using system packages in addition to pip?
> 
> I have a partial patch in this direction - I suggest adding things
> like
> py{27,35}-{xenial,jessie,etc} that install the versions known to be
> available on those platforms.

Do be aware that those packages frequently carry backports from newer
versions and might be different to the version found in pip. Testing
with _actual_ system packages would be a far better indicator.

Also - I ran these tests last night and it took over an hour. That's a
bit long for anything non-automated, I think. Must find a better way.

Cheers,
Stephen


More information about the Patchwork mailing list