[PATCH v2 5/7] parser: subject_check needs to call clean_header
stephen at that.guru
Thu Sep 29 03:10:44 AEST 2016
On 28 Sep 15:22, Daniel Axtens wrote:
> When testing with headers with unencoded characters on Py3,
> subject_check would fail. It was getting an Header class, rather
> than a str/bytes, and so the regex was failing.
> Run clean_header to decode everything fully first.
> Signed-off-by: Daniel Axtens <dja at axtens.net>
Reviewed-by: Stephen Finucane <stephen at that.guru>
> patchwork/parser.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/patchwork/parser.py b/patchwork/parser.py
> index fbc36125c2ec..b0a841176aaf 100644
> --- a/patchwork/parser.py
> +++ b/patchwork/parser.py
> @@ -422,7 +422,7 @@ def subject_check(subject):
> """Determine if a mail is a reply."""
> comment_re = re.compile(r'^(re)[:\s]\s*', re.I)
> - return comment_re.match(subject)
> + return comment_re.match(clean_header(subject))
> def clean_content(content):
More information about the Patchwork