[PATCH v3 2/7] models: Add 'Series' model and related models

Damien Lespiau damien.lespiau at intel.com
Fri Sep 16 20:42:50 AEST 2016


On Fri, Sep 16, 2016 at 03:10:15PM +1000, Daniel Axtens wrote:
> Hi,
> 
> > + at python_2_unicode_compatible
> > +class SeriesRevision(models.Model):
> > +
> > +    group = models.ForeignKey(Series, related_name='revisions',
> > +                              related_query_name='revision', null=True,
> > +                              blank=True)
> > +    date = models.DateTimeField()
> > +    submitter = models.ForeignKey(Person)
> > +    version = models.IntegerField(default=1,
> > +                                  help_text='Version of series revision as '
> > +                                  'indicated by the subject prefix(es)')
> > +    total = models.IntegerField(help_text='Number of patches in series as '
> > +                                'indicated by the subject prefix(es)')
> > +
> 
> OK, so I've been thinking about this and having some chats around the
> office.
> 
> One of the things that keeps coming up in discussions about series
> support is "What do we call a series?". Currently we look at the cover
> letter, if present, and then there's been quite a bit of debate about
> what to do if a cover letter is not present.
> 
> Personally, I've been thinking about how I remember people talking about
> series. I remember saying things like "Bob's hotplug series", "Jane's
> Radix MMU series", "Daniel's sparse patch series" or "Ben's PCI
> cleanups".
> 
> I'd quite like patchwork to be able to represent patch series in a way
> that matches as naturally as possible with how the humans who use
> Patchwork perceive them.
> 
> As such, I'd like it if we could name series. And I'd like at least
> maintainers, or perhaps series authors, etc. to be able to give series
> names in patchwork. I don't really mind whether this attaches to a
> Series or to a SeriesRevision.
> 
> I realise this makes the models a bit more heavy-weight.
> 
> Thoughts?

This seems to be the conclusion I arrived to about 1 year ago,
unfortunately I wasn't able to convince people that was the way to go.

  https://patchwork.freedesktop.org/project/intel-gfx/series/?ordering=-last_updated

I even had the same (natural!) idea around being able (re-)name series
in patchwork:

  https://github.com/dlespiau/patchwork/issues/9

Series model:
  
  https://github.com/dlespiau/patchwork/blob/master/patchwork/models.py#L506

-- 
Damien


More information about the Patchwork mailing list