[PATCH v3 2/7] models: Add 'Series' model and related models

Andrew Donnellan andrew.donnellan at au1.ibm.com
Thu Sep 15 14:19:18 AEST 2016

On 13/09/16 07:53, Stephen Finucane wrote:
> Add a series model. This model is intentionally very minimal to allow
> as much dynaminism as possible. It is expected that patches will be
> migrated between series as new data is provided.
> Signed-off-by: Stephen Finucane <stephenfinucane at hotmail.com>
> Co-authored-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Please Cc me on tags.

> Reviewed-by: Andy Doan <andy.doan at linaro.org>
> ---
> v2:
> - Resolve issue with REST API (Andrew Donnellan)

Um... this hasn't been fixed at all.

I'm working on proper REST support.

> - Use more meaningful names for untitled series (Andrew Donnellan)

This isn't a huge improvement. I'd prefer to see the title of patch #1 
used as the series title if the series doesn't have a cover letter 
(perhaps with a visual indicator like an asterisk or something). I know 
Daniel also has some opinions on this.

More detailed review when I have time.

Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited

More information about the Patchwork mailing list