"xmlrpc: Don't load all Patches into memory" breaking Django 1.6 and 1.7

Stephen Finucane stephenfinucane at hotmail.com
Fri Sep 2 06:34:48 AEST 2016

On 25 Aug 11:19, Daniel Axtens wrote:
> Hi!
> I've pulled the latest master, and I'm now getting the following failure
> on Django 1.6 and 1.7.
> FAIL: test_list_negative_max_count (patchwork.tests.test_xmlrpc.XMLRPCTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/patchwork/patchwork/patchwork/tests/test_xmlrpc.py", line 65, in test_list_negative_max_count
>     self.assertEqual(patches[0]['id'], patch_objs[-1].id)
> AssertionError: 1 != 5L
> It was introduced by 5b70ecf7d318 - reverting it makes the failure go
> away. I haven't investigated in any more detail yet.

I don't know why I didn't pick it up earlier, tbh, but this actually
looks like an issue with these Django versions (or, more likely, we're
doing something dumb). I'm replaced these with a slightly slower, but
just as effective solution here:


Would appreciate the review.


More information about the Patchwork mailing list