[PATCH v2 2/4] docs: Make Docker the recommended install method

Stephen Finucane stephenfinucane at hotmail.com
Fri Sep 2 04:23:21 AEST 2016


On 01 Sep 19:09, Stephen Finucane wrote:
> On 31 Aug 10:07, Daniel Axtens wrote:
> > 
> > Your changes look good - I did find a couple of other minor nits though:
> > 
> > > +To run unit tests, excluding Selenium UI interaction tests, using only the
> > > +package versions provided by the container, run:
> > > +
> > > +    $ docker-compose run --rm web --quick-test
> > 
> > I'm not quite sure this is correct. In terms of python packages, it uses
> > the versions installed by pip. It does use Python versions and other
> > packages (e.g. chromium) supplied by Ubuntu, but that's about it...
> > 
> 
> Good point. I'll change this to 'installed during container
> initialization'
> 
> > > +
> > > +To run the same against all supported versions of Django (via tox), run:
> > > +
> > > +    $ docker-compose run --rm web --quick-tox
> > > +
> > > +To run all tests, including Selenium run headlessly, using only the package
> > > +versions provided by the container, run:
> > 
> > Likewise here.
> 
> Ditto.
> 
> > > +
> > > +    $ docker-compose run --rm web --test
> > > +
> > > +To run the same against all supported versions of Django (via tox), run:
> > > +
> > > +    $ docker-compose run --rm web --tox
> > > +
> > > +To run all tests in non-headless tests:
> > "in non-headless mode"?
> 
> Yup.
> 
> > > +
> > Once those are sorted:
> > Reviewed-by: Daniel Axtens <dja at axtens.net>
> 
> I'll fix the above and merge this. Thanks for the review :)
> 
> Stephen

Merged.


More information about the Patchwork mailing list