[PATCH] views: Update how patch counts are retrieved

Daniel Axtens dja at axtens.net
Thu Oct 27 22:48:57 AEDT 2016


Stephen Finucane <stephen at that.guru> writes:

> On 2016-10-20 21:30, Daniel Axtens wrote:
>> Stephen Finucane <stephen at that.guru> writes:
>> 
>>> It's no longer possible to access 'Project.patch_set' as
>>> 'Project.submission_set' has replaced it. This was missed when the
>>> cover letter feature was merged, so resolve it now.
>>> 
>>> Signed-off-by: Stephen Finucane <stephen at that.guru>
>>> Closes-bug: #54
>> 
>> Hmm. Evidently our tests didn't pick this up, which is a bit
>> disappointing. It would be good to check that all the views succeed,
>> both with and without data. I haven't been able to find any package or
>> trick to enumerate the views and test them automatically, which is a 
>> bit
>> of a shame, but failing that we could just test them manually...
>
> Yeah, we'll add an integration test for this in a follow-up patch. You 
> happy for this to go in as-is for now though?

Sorry, I missed this somehow. Yeah, I'm good for it to go through.
Daniel

>
> Stephen


More information about the Patchwork mailing list