[PATCH v6 1/8] models: Convert functions to properties

Daniel Axtens dja at axtens.net
Tue Oct 25 17:34:15 AEDT 2016

Stephen Finucane <stephen at that.guru> writes:

> On 2016-10-17 22:56, Daniel Axtens wrote:
>> Stephen Finucane <stephen at that.guru> writes:
>>> -    def sync_person(self):
>>> -        pass
>>> -
>>> +    def sync_person(self):
>>> +        pass
>>> +
>> Not sure why you're moving sync_person here. Doesn't really matter or
>> need a respin but it might be worth trying to drop these hunks when
>> merging.
> Ah - that was done just to group all '@property' items together. I'll 
> actually drop it when applying seeing as it's useless anyway and removed 
> in another patch.

Sorry to have taken so long to get back to you. Still working on the
rest of the series.

Given that you're dropping these:
Reviewed-by: Daniel Axtens <dja at axtens.net>

> Stephen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20161025/fdc78289/attachment.sig>

More information about the Patchwork mailing list