[PATCH v6 1/8] models: Convert functions to properties

Daniel Axtens dja at axtens.net
Tue Oct 18 09:56:46 AEDT 2016


Stephen Finucane <stephen at that.guru> writes:
  
> -    def sync_person(self):
> -        pass
> -

> +    def sync_person(self):
> +        pass
> +

Not sure why you're moving sync_person here. Doesn't really matter or
need a respin but it might be worth trying to drop these hunks when
merging.

I haven't checked all the call-sites for everything you've marked as
property, but I trust that between you, Andy and the test suite that
it's all correct :)

Regards,
Daniel


More information about the Patchwork mailing list