Delegate-To: and Reviewers: HOWTO ?

[Stephen Finucane]

On 23 Aug 16:30, Pat Noziska wrote:
> 
> Forgive me in advance if this is already in the Patchwork list archives -
> there's no search function in the archives page that I can see ;-) , and I
> can find no other documentation on this..
> 
> Is there any documentation out there on the purpose and proper usage of
> Delegate and Reviewer features in Patchwork?

I just submitted some here:

https://patchwork.ozlabs.org/patch/680853/
https://patchwork.ozlabs.org/patch/680854/

Questions answered below for future reference.

> I want to use those attributes to assign patches for review/approval within
> a team and track their review status.
> 
> Specifically:
> 
> 1. In the Projects admin page, how does one correctly set up delegation
>    rules - what is the correct syntax of the Path attribute (e.g. are
>    regular expressions allowed), how can a delegation rule be applied
>    to multiple users, does this trigger automatic delegation, and what
>    notification does a Delegate receive when a patch is Delegated to a
>    user? Can patch status be made dependent on comments from Delegates?

1. The fnmatch library is used, which allows for some basic
   wildcarding.

2. A patch can only be assigned to a single delegate, thus, a
   delegation rule can only assign one user.

3. Yes, it automatically delegates to said user on patch receipt

4. I don't know if there's any notification on delegation actually. Let
   me get back to you on that one :)

5. I'm not sure what you mean. Can you elaborate?

> 2. If a delegation rule doesn't exist that would apply to a given
>    patch, how can one produce a list of potential delegates that a
>    patch can be delegated to?

A delegate is anyone that has maintainer rights set for the project
[*]. You can look at the '/project/<project_name>' page to see this
list.

> 3. What Is the difference between a Delegate (as shown in the Patch
>    view) and a Reviewer (as shown in the Series view) ?  How is a
>    Reviewer determined?

You're refering to the freedesktop instance, I assume? I'm afraid
that's different to upstream so you'll have to direct that questions to
the maintainer of said instance. At a quick glance, theyy appear to be
the same thing, albeit one being for patches and the other for series.

> In general, I need a HOWTO on Delegates and Reviewers? Can you help?

Hope this helps, and sorry for taking so damn long to get back to you.
This slipped through my radar somehow :S

Stephen

[*] This wasn't technically true for v1.1.0 and v1.1.1, as we merged a
    feature to allow delegation to all users. This has since been
    reverted though so you probably won't see this anymore.