[PATCH v2 06/13] REST: Stop using ViewSets

Stephen Fincane stephen at that.guru
Fri Nov 25 06:58:50 AEDT 2016

On Mon, 2016-11-21 at 14:27 +1100, Daniel Axtens wrote:
> Hi Stephen,
> > 
> > These are hacked a lot of to get them to work as we want. Use a
> > more
> > verbose, but ultimately easier to parse, version. This lets us
> > remove
> > the dependency of drf-nested-routers, bringing us back down to two
> > main
> > dependencies. It also lets us remove the AuthenticedReadOnly
> > permission
> > class, as the generic views enforce this for us.
> > 
> > The main user facing change is the use of 405 (Method Not Allowed)
> > errors when trying to use an invalid method, such as POST on the
> > project endpoint.
> I'm not 100% clear the meaning of this commit message. What was the
> behaviour before and what is the behaviour now? I think you're saying
> a
> user will now see a 405?

I've clarified this in the next revision.

> Beyond that, I'm really not qualified to comment, and given that
> we're
> spinning a new API version, if Andrew and Russell are happy with it,
> I'm
> happy!
> If you really want a reviewed-by I can come to grips with DRF but it
> will take a while.

To be honest, a quick perusal of the web interface for the API and
running of the tests should show that things are as expected. Outside
of that, let's wait for the other folks as you suggest.


More information about the Patchwork mailing list