[PATCH 2/4] tox: Remove lint target

Daniel Axtens dja at axtens.net
Mon Nov 7 10:28:53 AEDT 2016


Stephen Finucane <stephen at that.guru> writes:

> On 2016-10-31 20:57, Daniel Axtens wrote:
>>> pylint doesn't work very well with Django, and this is broken.
>> 
>> Interesting. I've been carrying the following local patch:
>> 
>> diff --git a/tox.ini b/tox.ini
>> index 0836cd52ae1d..940daf01e29e 100644
>> --- a/tox.ini
>> +++ b/tox.ini
>> @@ -36,7 +36,7 @@ exclude = ./patchwork/migrations
>>  basepython = python2.7
>>  deps =
>>      pylint
>> -    -r{toxinidir}/requirements-prod.txt
>> +    -r{toxinidir}/requirements-test.txt
>>  commands = pylint patchwork --rcfile=pylint.rc
>> 
>>  [testenv:venv]
>> 
>> That gets things going, but I haven't followed-up on the list of things
>> it throws up, so if you think the list is useless I'm happy to go with
>> your patch.
>
> Yeah, it gets things working but there are a lot of false positives. If 
> this is something someone's using then I guess we could keep it (after 
> applying your patch, that is)? In any case, I've the other patches in 
> this series applied.
>

I haven't gone though the results so I wouldn't really know. Your call -
we already have flake8 so I don't really mind if we drop down to a
single linter.

Regards,
Daniel

> Stephen


More information about the Patchwork mailing list