[PATCH 2/4] tox: Remove lint target

Daniel Axtens dja at axtens.net
Tue Nov 1 07:57:26 AEDT 2016


> pylint doesn't work very well with Django, and this is broken.

Interesting. I've been carrying the following local patch:

diff --git a/tox.ini b/tox.ini
index 0836cd52ae1d..940daf01e29e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -36,7 +36,7 @@ exclude = ./patchwork/migrations
 basepython = python2.7
 deps =
     pylint
-    -r{toxinidir}/requirements-prod.txt
+    -r{toxinidir}/requirements-test.txt
 commands = pylint patchwork --rcfile=pylint.rc
 
 [testenv:venv]

That gets things going, but I haven't followed-up on the list of things
it throws up, so if you think the list is useless I'm happy to go with
your patch.

Regards,
Daniel

>
> Signed-off-by: Stephen Finucane <stephen at that.guru>
> Cc: Daniel Axtens <dja at axtens.net>
> ---
>  tox.ini | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/tox.ini b/tox.ini
> index 0836cd5..c700b54 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -32,16 +32,6 @@ commands = flake8 {posargs} patchwork patchwork/bin/pwclient
>  ignore = E129, F405
>  exclude = ./patchwork/migrations
>  
> -[testenv:lint]
> -basepython = python2.7
> -deps =
> -    pylint
> -    -r{toxinidir}/requirements-prod.txt
> -commands = pylint patchwork --rcfile=pylint.rc
> -
> -[testenv:venv]
> -commands = {posargs}
> -
>  [testenv:coverage]
>  basepython = python2.7
>  deps =
> @@ -54,3 +44,6 @@ commands =
>      coverage run --omit=*tox*,patchwork/tests/*.py,manage.py,patchwork/migrations/*.py \
>           --branch {toxinidir}/manage.py test --noinput patchwork
>      coverage report -m
> +
> +[testenv:venv]
> +commands = {posargs}
> -- 
> 2.7.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/patchwork/attachments/20161101/285a016c/attachment.sig>


More information about the Patchwork mailing list