[PATCH v3 03/10] REST: Add Projects to the API

Andy Doan andy.doan at linaro.org
Sat May 21 06:12:58 AEST 2016

On 05/19/2016 02:03 AM, Finucane, Stephen wrote:
>> +    page_size = settings.REST_RESULTS_PER_PAGE
> nit: This is already a DRF-provided setting that we can override:
>    http://www.django-rest-framework.org/api-guide/settings/#page_size
> However, Given the deprecation of other similar parameters, I'm fine to
> stick with our own parameter (those settings might be worth reading
> though, in case there's anything cool there :)).

I thought PAGE_SIZE was really generic and would wind up causing a 
comment line in code. So I figured using our own setting would make it 
more clear/obvious.

More information about the Patchwork mailing list