[PATCHv2 06/10] REST: Add Patch Checks to the API
Finucane, Stephen
stephen.finucane at intel.com
Tue May 17 23:27:30 AEST 2016
On 17 May 14:14, Finucane, Stephen wrote:
> On 10 May 17:39, Andy Doan wrote:
> > This exports patch checks via the REST API.
> >
> > The drf-nested-routers package is used to handle the fact Checks are
> > nested under a Patch.
> >
> > Security Constraints:
> > * Anyone (logged in or not) can read all objects.
> > * No one can update/delete objects.
> > * Project maintainers and patch owners may create objects.
> >
> > Signed-off-by: Andy Doan <andy.doan at linaro.org>
>
> I won't review this in-depth until v3, pending inclusion of a 'check'
> field in the 'patches' response. I will add, however, that when I go to
> 'patches/{patchID}/check' for a patch with no checks, I get the
> following response:
>
> HTTP 200 OK
> Allow: GET, HEAD, OPTIONS
> Content-Type: application/json
> Vary: Accept
>
> {
> "state": 0
> }
>
> This doesn't look correct (it should have a string value): could you
> investigate?
Also, you have DRF specified twice in the 'settings-dev.py' file.
Stephen
More information about the Patchwork
mailing list