[PATCH] parsemail: Fix return value for find_content error case

Finucane, Stephen stephen.finucane at intel.com
Tue Mar 29 19:48:24 AEDT 2016

On 28 Mar 11:31, Jeremy Kerr wrote:
> If we fail to decode a message payload, we'll fail with the following:
>   Traceback (most recent call last):
>     File "./patchwork/bin/parsemail.py", line 563, in <module>
>       sys.exit(main(sys.argv))
>     File "./patchwork/bin/parsemail.py", line 553, in main
>       return parse_mail(mail, args['list_id'])
>     File "./patchwork/bin/parsemail.py", line 464, in parse_mail
>       (patch, comment, filenames) = find_content(project, mail)
>   ValueError: need more than 2 values to unpack
> - as the error condition for find_content only returns a 2-tuple. This
> change fixes the error case to the 3-tuple return type.
> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>

Damn. I'd fixed this for the cover letter work but never backported it.
Done now though. Thanks again.


More information about the Patchwork mailing list