[PATCH v2 3/3] fields: Simplify HashField

Finucane, Stephen stephen.finucane at intel.com
Wed Mar 16 20:42:29 AEDT 2016


On 15 Mar 16:18, Andy Doan wrote:
> On 03/15/2016 06:27 AM, Stephen Finucane wrote:
> >The HashField was written to be configurable. It supports customisable
> >hash types and provides fallbacks for a missing 'hashlib', which was
> >only introduced in Python 2.5. However, the customisable hash types
> >are not used anywhere (the actual hashing is hardcoded to use 'sha1')
> >and Python 2.7/3.3+ are the only versions of Python currently
> >supported. As a result, it is possible to remove much of the code
> >without losing any real functionality. Do this.
> >
> >Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>
> 
> Reviewed-by: Andy Doan <andy.doan at linaro.org>

Merged.


More information about the Patchwork mailing list