[PATCH 3/3] models: Pull common email behavior into mixin
andy.doan at linaro.org
Sat Mar 12 19:39:03 AEDT 2016
On 03/08/2016 03:54 PM, Stephen Finucane wrote:
> A "Patch" and "Comment" share a common ancestor: emails. As a result
> of this many fields are similar between the two. Rather than
> duplicating code, pull the similar code out of the aforementioned
> classes and into a Mixin.
> This has the side effect of removing restrictions on Comment.content,
> but this is probably OK: it's possible that someone could send an
> empty mail in reply to a patch and we should show that.
> Signed-off-by: Stephen Finucane <stephen.finucane at intel.com>
I wasn't able to fully test this, but I like the idea and direction:
Reviewed-by: Andy Doan <andy.doan at linaro.org>
More information about the Patchwork