[PATCH 07/10] Report if a patch is delagated and to whom

Finucane, Stephen stephen.finucane at intel.com
Thu Jan 7 04:19:05 AEDT 2016


On 24 Dec 18:31, Mauro Carvalho Chehab wrote:

[snip]

> > You seem to be missing a couple of dependencies here: it fails to run
> > because of missing imports and the code looks like a minor modification
> > of functionality found in 'patchwork/views/__init__.py'. 
> 
> Hmm.. it runs fine at patchwork, but perhaps due to some other
> locale changes I did there, for patchwork to find the dependencies.
> 
> > Is there any
> > reason we can't just include the above 'X-Patchwork-Delegate' lines in
> > the 'patch_to_mbox' function found in the aforementioned file?
> 
> I remember I tried to add it on some other place (don't remember where
> anymore, as it was done several years ago). It didn't work when the
> patch were obtained via XMLRPC.
> 
> I need to receive this tag via pwclient, as my local scripts use it
> to remove patches delegated to other developers from my own work
> queue.
> 
> Anyway, feel free to either modify this patch or do to something else
> that would provide the same functionality. I'm not a Pyhton expert.
> So, I'm probably not taking the best approach ;)

OK, I have it merged into the existing file and it's working for me.
I also have unit tests added. As such, I'm rejecting this one but
will merge a modified version. That OK? :)

Stephen


More information about the Patchwork mailing list