[PATCH 09/19] ui: Use <h1> for page titles

Stephen Finucane stephen.finucane at intel.com
Thu Feb 4 08:31:44 AEDT 2016


From: Damien Lespiau <damien.lespiau at intel.com>

<h2> is used for titles within the page, but shouldn't be used for page
titles, which are a level higher.

Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
Acked-by: Stephen Finucane <stephen.finucane at intel.com>
---
 patchwork/templates/patchwork/bundles.html    | 1 +
 patchwork/templates/patchwork/list.html       | 2 +-
 patchwork/templates/patchwork/patch.html      | 2 +-
 patchwork/templates/patchwork/profile.html    | 1 +
 patchwork/templates/patchwork/project.html    | 1 +
 patchwork/templates/patchwork/todo-list.html  | 1 +
 patchwork/templates/patchwork/todo-lists.html | 1 +
 7 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/patchwork/templates/patchwork/bundles.html b/patchwork/templates/patchwork/bundles.html
index 35235fb..6467a30 100644
--- a/patchwork/templates/patchwork/bundles.html
+++ b/patchwork/templates/patchwork/bundles.html
@@ -7,6 +7,7 @@
 {% block bundle_active %}active{% endblock %}
 
 {% block body %}
+<h1>Bundles</h1>
 
 {% if bundles %}
 <table class="bundlelist">
diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html
index df25bb5..fc33d7b 100644
--- a/patchwork/templates/patchwork/list.html
+++ b/patchwork/templates/patchwork/list.html
@@ -9,7 +9,7 @@
 
 {% block body %}
 
-<h2>Incoming Patches</h2>
+<h1>Patches</h1>
 
 {% if errors %}
 <p>The following error{{ errors|length|pluralize:" was,s were" }} encountered
diff --git a/patchwork/templates/patchwork/patch.html b/patchwork/templates/patchwork/patch.html
index b5d0eb7..ae9355d 100644
--- a/patchwork/templates/patchwork/patch.html
+++ b/patchwork/templates/patchwork/patch.html
@@ -27,7 +27,7 @@ function toggle_headers(link_id, headers_id)
 }
 </script>
 
-<h2>{{ patch.name }}</h2>
+<h1>{{ patch.name }}</h1>
 <div class="core-info">
     <span>Submitted by {{ patch.submitter|personify:project }} on {{ patch.date }}</span>
 </div>
diff --git a/patchwork/templates/patchwork/profile.html b/patchwork/templates/patchwork/profile.html
index acc90de..2ec2db1 100644
--- a/patchwork/templates/patchwork/profile.html
+++ b/patchwork/templates/patchwork/profile.html
@@ -5,6 +5,7 @@
 
 
 {% block body %}
+<h1>Your Profile</h1>
 
 <p>
 {% if user.profile.maintainer_projects.count %}
diff --git a/patchwork/templates/patchwork/project.html b/patchwork/templates/patchwork/project.html
index 5238ba4..b84e5dc 100644
--- a/patchwork/templates/patchwork/project.html
+++ b/patchwork/templates/patchwork/project.html
@@ -5,6 +5,7 @@
 {% block info_active %}active{% endblock %}
 
 {% block body %}
+<h1>About {{project.name}}</h1>
 
 <table class="horizontal">
  <tr>
diff --git a/patchwork/templates/patchwork/todo-list.html b/patchwork/templates/patchwork/todo-list.html
index b301901..5e60446 100644
--- a/patchwork/templates/patchwork/todo-list.html
+++ b/patchwork/templates/patchwork/todo-list.html
@@ -6,6 +6,7 @@
 {% block heading %}{{user}}'s todo list for {{ project.linkname }}{% endblock %}
 
 {% block body %}
+<h1>TODO</h1>
 
 <p>A Patchwork Todo-list contains patches that are assigned to you, and
 are in an "action required" state
diff --git a/patchwork/templates/patchwork/todo-lists.html b/patchwork/templates/patchwork/todo-lists.html
index 6365f59..352ca5d 100644
--- a/patchwork/templates/patchwork/todo-lists.html
+++ b/patchwork/templates/patchwork/todo-lists.html
@@ -4,6 +4,7 @@
 {% block heading %}{{ user }}'s todo lists{% endblock %}
 
 {% block body %}
+<h1>TODO</h1>
 
 {% if todo_lists %}
 <p>You have multiple todo lists. Each todo list contains patches for a single
-- 
2.0.0



More information about the Patchwork mailing list